v1.18: Discard packets statically known to fail (backport of #370)#375
Merged
v1.18: Discard packets statically known to fail (backport of #370)#375
Conversation
* Discard packets statically known to fail * add test (cherry picked from commit 5f16932) # Conflicts: # core/src/banking_stage/transaction_scheduler/scheduler_controller.rs
Author
|
Cherry-pick of 5f16932 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
apfitzge
reviewed
Mar 21, 2024
Comment on lines
+275
to
276
| .receive_packets(recv_timeout, remaining_queue_capacity, |_| true)); | ||
| saturating_add_assign!(self.timing_metrics.receive_time_us, receive_time_us); |
There was a problem hiding this comment.
there was a merge conflict here due to metric accumulation change in master. see 1fc684b for resolve
anwayde
pushed a commit
to firedancer-io/agave
that referenced
this pull request
Jul 23, 2024
…#370) (anza-xyz#375) * Discard packets statically known to fail (anza-xyz#370) * Discard packets statically known to fail * add test (cherry picked from commit 5f16932) # Conflicts: # core/src/banking_stage/transaction_scheduler/scheduler_controller.rs * resolve conflicts: old metrics update style --------- Co-authored-by: Andrew Fitzgerald <apfitzge@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Summary of Changes
Fixes #
This is an automatic backport of pull request #370 done by [Mergify](https://mergify.com).