transaction-error: Fix warning for bpf build, feature gating#3742
Merged
Conversation
#### Problem There's a warning when building solana-transaction-error in bpf: ``` warning: unused import: `std::io` --> sdk/transaction-error/src/lib.rs:8:93 | 8 | ...or, solana_sanitize::SanitizeError, std::io, ``` This is because the part that uses std::io is gated on `not(target_os = "solana")`. Also, clippy is failing on this crate individually because the "serde" feature is not enabled on solana-instruction. #### Summary of changes Fix those two things.
Merged
kevinheavey
approved these changes
Nov 22, 2024
joncinque
added
the
automerge
febo
approved these changes
Nov 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
There's a warning when building solana-transaction-error in bpf:
This is because the part that uses std::io is gated on
not(target_os = "solana").Also, clippy is failing on this crate individually because the "serde" feature is not enabled on solana-instruction.
Summary of changes
Fix those two things.