Revert "Marks old storages as dirty in clean_accounts() (#3702)"#3735
Merged
brooksprumo merged 1 commit intoanza-xyz:masterfrom Nov 22, 2024
Merged
Conversation
HaoranYi
approved these changes
Nov 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The idea is right, but we also need to add old storages to the uncleaned roots list. Since this work needs to be backported, we're going to revert this partial impl, and then do a proper impl1 in another PR. That that other PR will the one we backport.
Summary of Changes
This reverts commit bf33b8c, PR #3702.
Footnotes
the proper impl is here: Marks old storages as dirty and uncleaned in clean_accounts() #3737 ↩