move sdk crates to sdk dir#3498
Merged
joncinque merged 2 commits intoanza-xyz:masterfrom Nov 6, 2024
Merged
Conversation
Author
|
CI failure |
|
The change looks good to me! Can you disable the downstream SPL jobs with a few |
kevinheavey
added
the
automerge
kevinheavey
force-pushed
the
move-sdk-crates
branch
from
ffeb377 to
7f51c6e
Compare
anza-team
removed
the
automerge
Collaborator
|
😱 New commits were pushed while the automerge label was present. |
Author
|
Had to fix conflicts |
joncinque
approved these changes
Nov 6, 2024
kevinheavey
added
the
automerge
Author
|
@joncinque could you merge? Looks like automerge isn't firing |
joncinque
added a commit
to joncinque/solana-program-library
that referenced
this pull request
Nov 6, 2024
#### Problem The locations of crates in the monorepo was moved to the `sdk/` dir in anza-xyz/agave#3498, but the patch script is still looking in the wrong location. This is why the downstream job was disabled in that PR. #### Summary of changes Get the patch script up to date with the new locations of the crates.
joncinque
added a commit
to solana-labs/solana-program-library
that referenced
this pull request
Nov 6, 2024
#### Problem The locations of crates in the monorepo was moved to the `sdk/` dir in anza-xyz/agave#3498, but the patch script is still looking in the wrong location. This is why the downstream job was disabled in that PR. #### Summary of changes Get the patch script up to date with the new locations of the crates.
joncinque
added a commit
that referenced
this pull request
Nov 7, 2024
* CI: Re-enable downstream SPL job #### Problem The downstream SPL job was disabled in #3498 because the moved crates weren't correctly picked up in the SPL's patch script. The SPL patch script was fixed in solana-labs/solana-program-library#7465, but the jobs are still disabled. #### Summary of changes Re-enable the SPL downstream jobs. * Restrict which repo runs the job
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
There are some crates that solana-sdk depends on that do not live in the sdk/ directory. The SDK crates will get moved to a new repo at some point and we don't want these to get missed
Summary of Changes
Move them