remove vote-program dep from rpc-client#3462
Merged
mergify[bot] merged 2 commits intoNov 25, 2024
Merged
Conversation
Author
|
Coverage failure is unrelated |
kevinheavey
force-pushed
the
rpc-client-rm-vote-program
branch
from
488c8fd to
d45e673
Compare
joncinque
reviewed
Nov 25, 2024
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Looks good to me -- can you rebase to also make the lockfile change to svm/examples/Cargo.lock?
kevinheavey
force-pushed
the
rpc-client-rm-vote-program
branch
from
d45e673 to
2ab745e
Compare
joncinque
approved these changes
Nov 25, 2024
joncinque
added
the
automerge
|
automerge label removed due to a CI failure |
mergify
Bot
removed
the
automerge
|
This needs a rebase on top of #3774 for CI to pass |
kevinheavey
force-pushed
the
rpc-client-rm-vote-program
branch
from
2ab745e to
3d51a4a
Compare
joncinque
added
the
automerge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
solana-rpc-client is depending on solana-vote-program just for a const that it re-exports from solana_program
Summary of Changes
Don't do that