implement get_builtin_program_ids() trait for TransactionProcessingCallback

[Nagaprasadvr]

Fixes Issue #303

Improvement

1. In order to use the SVM, we must register the builtins as it is now done in the add_builtin function in bank.rs (link), and then pass them to load_and_execute_sanitized_transactions as a vector of public keys.
   instead of this we can implement get_builtin_programs() trait to TransactionProcessingCallback and get builtin_programs inside load_and_execute_sanitized_transactions fn

Summary of Changes

1. Implement trait get_builtin_programs() for TransactionProcessingCallback
2. remove vec of builtin_program passed as an array of pubkeys to load_and_execute_sanitized_transactions

[buffalojoec]

How soon do you need this method exposed? It's included in this PR here.

#79

This commit: 735bcfd

[Nagaprasadvr]

How soon do you need this method exposed? It's included in this PR here.

#79

This commit: 735bcfd

U can close this , im fine with your pr

[buffalojoec]

How soon do you need this method exposed? It's included in this PR here.
#79
This commit: 735bcfd

U can close this , im fine with your pr

Cool I'll link back here when mine goes in. Thanks for contributing! You can still probably rebase yours and add the callback bit if you wanted!

[buffalojoec]

@Nagaprasadvr My commit went in if you wanted to rebase your changes!

[Nagaprasadvr]

@Nagaprasadvr My commit went in if you wanted to rebase your changes!

hey thanks will do that

[LucasSte]

1. In order to use the SVM, we must register the builtins as it is now done in the add_builtin function in bank.rs (link), and then pass them to load_and_execute_sanitized_transactions as a vector of public keys.
   instead of this we can implement get_builtin_programs() trait to TransactionProcessingCallback and get builtin_programs inside load_and_execute_sanitized_transactions fn

Note that the core idea behind the issue is not just to eliminate the vector of builtins to load_and_execute_sanitized_transactions. The SVM is now offered as a separate create than the rest of runtime, and ideally, we would register the builtins directly on the SVM instead of doing it in bank. The SVM would keep a list of builtins it needs to account for during execution.

Your changes only eliminate the builtin from the function, but do not account for the needed re design. This PR does not fix the issue. It is only a step towards the planned refactor.

Either way, the refactor must only come after #79 is merged.

[Nagaprasadvr]

1. In order to use the SVM, we must register the builtins as it is now done in the add_builtin function in bank.rs (link), and then pass them to load_and_execute_sanitized_transactions as a vector of public keys.
   instead of this we can implement get_builtin_programs() trait to TransactionProcessingCallback and get builtin_programs inside load_and_execute_sanitized_transactions fn

Note that the core idea behind the issue is not just to eliminate the vector of builtins to load_and_execute_sanitized_transactions. The SVM is now offered as a separate create than the rest of runtime, and ideally, we would register the builtins directly on the SVM instead of doing it in bank. The SVM would keep a list of builtins it needs to account for during execution.

Your changes only eliminate the builtin from the function, but do not account for the needed re design. This PR does not fix the issue. It is only a step towards the planned refactor.

Either way, the refactor must only come after #79 is merged.

I see that issue is updated will make changes accordingly

[LucasSte]

Superseded by #547