Rename and uniquify QUIC thread names#28
Merged
steviez merged 2 commits intoanza-xyz:masterfrom Mar 5, 2024
Merged
Conversation
yihau
force-pushed
the
master
branch
2 times, most recently
from
91aae97 to
3f9a7a5
Compare
When viewing in various tools such as gdb and perf, it is not easy to distinguish which threads are serving which function (TPU or TPU FWD)
steviez
force-pushed
the
quic_thread_name
branch
from
47a1bd6 to
4ce3bbe
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #28 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 837 837
Lines 225922 225923 +1
=========================================
- Hits 184955 184936 -19
- Misses 40967 40987 +20 |
bw-solana
approved these changes
Mar 5, 2024
bw-solana
left a comment
bw-solana
left a comment
There was a problem hiding this comment.
Making good use of all 15 characters. Love to see it. LGTM
codebender828
pushed a commit
to codebender828/agave
that referenced
this pull request
Oct 3, 2024
When viewing in various tools such as gdb and perf, it is not easy to distinguish which threads are serving which function (TPU or TPU FWD)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The QUIC threads currently share names between TPU and TPU forwards. This obfuscates things when inspecting threads (
gdb,perf, etc).Summary of Changes
quic-client==>solQuicClientRtsolQuicServer==>solQuicTpu+solQuicTpuFwdquic-server==>solQuicTpuRt+solQuicTpuFwdRtThe
Rtdenotes that these threads belong to a tokio runtime