Skip to content

account_saver: optionally collect txs#2793

Merged
apfitzge merged 1 commit intoanza-xyz:masterfrom
apfitzge:accounts_saver_optional_txs
Sep 3, 2024
Merged

account_saver: optionally collect txs#2793
apfitzge merged 1 commit intoanza-xyz:masterfrom
apfitzge:accounts_saver_optional_txs

Conversation

@apfitzge
Copy link
Copy Markdown

Problem

  • transactions are only used for the account update notifier (geyser)
  • we should not waste our time collecting them if there is no notifier

Summary of Changes

  • optionally collect transactions

Fixes #

@apfitzge
Copy link
Copy Markdown
Author

based on #2773

@apfitzge apfitzge self-assigned this Aug 29, 2024
@apfitzge apfitzge force-pushed the accounts_saver_optional_txs branch from 0aadfe9 to b3585c2 Compare August 30, 2024 15:07
@apfitzge apfitzge marked this pull request as ready for review August 30, 2024 19:48
Copy link
Copy Markdown

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Copy Markdown

@jstarry jstarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@apfitzge apfitzge merged commit 6e83982 into anza-xyz:master Sep 3, 2024
@apfitzge apfitzge deleted the accounts_saver_optional_txs branch September 3, 2024 13:03
ray-kast pushed a commit to abklabs/agave that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants