v1.18: Combine builtin and BPF compute cost in cost model (backport of #29)#271
v1.18: Combine builtin and BPF compute cost in cost model (backport of #29)#271mergify[bot] wants to merge 2 commits intov1.18from
Conversation
* Combine builtin and BPF execution cost into programs_execution_cost since VM has started to consume CUs uniformly * update tests * apply suggestions from code review (cherry picked from commit 8f3f06c)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v1.18 #271 +/- ##
=========================================
+ Coverage 80.6% 81.6% +1.0%
=========================================
Files 827 827
Lines 224496 224486 -10
=========================================
+ Hits 181015 183264 +2249
+ Misses 43481 41222 -2259 |
There was a problem hiding this comment.
change lgtm, same as the change on master branch. diff for backport is a bit large but I'm okay with it, as much of it is simply renames or simple combination of 2 fields into a single one.
Please still get approval from @t-nelson, as I was the reviewer on original PR.
|
I'm hesitant to backport to v1.18 right now, since we're planning to recommend it for mainnet-beta in the next couple of weeks. Do you know how much block space gets wasted, on average, by the current implementation? |
|
The double counted built-ins CUs waste about 10-14% block space (last time I checked). Mango dashboard visualizes it nicely: the unfilled space in I'd like to see this being deployed to mainnet-beta, but I'd also agree it is not as critical. Happy to close this it if deemed so. |
|
Not going to bp to 1.18 |
Problem
feature gate solana-labs#30620 has been activated everywhere, SVM now consumes compute units uniformly for both builtins and BPF instructions. Cost Model should no longer estimate their cost separately.
Original PR: solana-labs#32080
Summary of Changes
programs_execution_cost, update metrics reporting as well.Fixes #
This is an automatic backport of pull request #29 done by [Mergify](https://mergify.com).