v2.0: gossip: ignore retransmitter signatures when comparing duplicate shreds (backport of #2673)#2699
Conversation
|
Cherry-pick of ff87ed9 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
637f6e1 to
36af908
Compare
|
This change fixes the duplicate blocks observed on testnet. When checking if 2 shreds constitute a duplicate, we compare the payloads for a mismatch. Currently on testnet if we receive a duplicate proof for this situation via gossip, we erroneously mark the block as duplicate. |
…duplicate shreds (backport of anza-xyz#2673) (anza-xyz#2699)"
…mparing duplicate shreds (backport of anza-xyz#2673) (anza-xyz#2699)"" This reverts commit 260f39c.
Problem
#1271 ignores the retransmitter signature when comparing shreds in order to generate a duplicate proof.
We need to do the same when verifying a duplicate proof received from gossip.
Summary of Changes
Ignore retransmitter signature when verifying a duplicate proof received through gossip
This is an automatic backport of pull request #2673 done by [Mergify](https://mergify.com).