Skip to content

remove disable_block_production_forwarding cli flag#2687

Merged
apfitzge merged 1 commit intoanza-xyz:masterfrom
apfitzge:forwarding_cli_arg
Aug 26, 2024
Merged

remove disable_block_production_forwarding cli flag#2687
apfitzge merged 1 commit intoanza-xyz:masterfrom
apfitzge:forwarding_cli_arg

Conversation

@apfitzge
Copy link
Copy Markdown

Problem

  • Flag adds operational complexity
  • If operators see issue(s) with staked partner forwarding, they should remove staked-partner configuration.

Summary of Changes

  • Remove disable-block-production-forwarding cli flag from validator

Fixes #

@apfitzge apfitzge marked this pull request as ready for review August 21, 2024 18:02
@apfitzge apfitzge requested review from steviez and t-nelson August 21, 2024 18:03
@apfitzge apfitzge self-assigned this Aug 21, 2024
@apfitzge
Copy link
Copy Markdown
Author

As discussed for backport of #1801 (#2285), this should be backported if #2285 gets merged.

Copy link
Copy Markdown

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and given that the flag doesn't exist in any release branch, no need for CHANGELOG entry

@apfitzge apfitzge merged commit df892c4 into anza-xyz:master Aug 26, 2024
@apfitzge apfitzge deleted the forwarding_cli_arg branch August 26, 2024 12:53
@apfitzge apfitzge added the v2.0 label Sep 12, 2024
@mergify
Copy link
Copy Markdown

mergify Bot commented Sep 12, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

mergify Bot pushed a commit that referenced this pull request Sep 12, 2024
apfitzge added a commit that referenced this pull request Sep 12, 2024
…#2687) (#2909)

remove disable_block_production_forwarding cli flag (#2687)

(cherry picked from commit df892c4)

Co-authored-by: Andrew Fitzgerald <apfitzge@gmail.com>
ray-kast pushed a commit to abklabs/agave that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants