[TieredStorage] Use BufWriter in TieredWritableFile#261
Merged
yhchiang-sol merged 1 commit intoanza-xyz:masterfrom Mar 18, 2024
Merged
[TieredStorage] Use BufWriter in TieredWritableFile#261yhchiang-sol merged 1 commit intoanza-xyz:masterfrom
yhchiang-sol merged 1 commit intoanza-xyz:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #261 +/- ##
=======================================
Coverage 81.9% 81.9%
=======================================
Files 836 836
Lines 226643 226652 +9
=======================================
+ Hits 185636 185647 +11
+ Misses 41007 41005 -2 |
Author
|
The write time improvement for HotStorage is huge! Around 7-8x faster. 
|
yhchiang-sol
changed the title
yhchiang-sol
force-pushed
the
ts-buf-writer
branch
from
a6941d4 to
cf66380
Compare
HaoranYi
approved these changes
Mar 18, 2024
HaoranYi
left a comment
HaoranYi
left a comment
There was a problem hiding this comment.
lgtm.
I assume that existing tests have already covered the changes in this PR.
Author
Yes, existing tests have already covered the changes in this PR. This PR has also run on mnb and pop-net as well. |
codebender828
pushed a commit
to codebender828/agave
that referenced
this pull request
Oct 3, 2024
#### Problem TieredWritableFile currently uses File instead of BufWriter. This will introduce more syscall when doing file writes. #### Summary of Changes This PR makes TieredWritableFile uses BufWriter to allow the write-call to be more optimized to reduce the number of syscalls. #### Test Plan Existing tiered-storage test. Will run experiments to verify its performance improvement. #### Dependency anza-xyz#260
OliverNChalk
pushed a commit
to OliverNChalk/agave
that referenced
this pull request
Nov 11, 2025
* various cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
TieredWritableFile currently uses File instead of BufWriter.
This will introduce more syscall when doing file writes.
Summary of Changes
This PR makes TieredWritableFile uses BufWriter to allow the
write-call to be more optimized to reduce the number of syscalls.
Test Plan
Existing tiered-storage test.
Will run experiments to verify its performance improvement.
Dependency
#260