v2.0: Runtime: Core BPF Migration: Add checks for executable program account (backport of #2483)#2516
Merged
Merged
Conversation
|
Requesting backport to 2.0 to ensure any upcoming feature gates to migrate programs will allow those programs to have the |
CriesofCarrots
approved these changes
Aug 12, 2024
2501babe
approved these changes
Aug 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the Core BPF migration module was being added to the runtime, the
executableflag for accounts was being deprecated, so checks for this flag were not added to the mechanisms for migrating and upgrading Core BPF programs. See #309.These changes were reverted, and the Core BPF migration code must be aware of the
executableflag on accounts.Additionally, even though the program can still be invoked via instruction, the program account must be set as
executablewhen performing a migration, to ensure allexecutableflag checks are successful on the new program.Summary of Changes
Two small changes:
executablewhen loading an existing Core BPF program in preparation for an upgrade.executable: truewhen performing a migration from builtin to BPF.This is an automatic backport of pull request Runtime: Core BPF Migration: Add checks for executable program account #2483 done by Mergify.