Skip to content

v2.0: Runtime: Core BPF Migration: Add checks for executable program account (backport of #2483)#2516

Merged
buffalojoec merged 1 commit into
v2.0from
mergify/bp/v2.0/pr-2483
Aug 19, 2024
Merged

v2.0: Runtime: Core BPF Migration: Add checks for executable program account (backport of #2483)#2516
buffalojoec merged 1 commit into
v2.0from
mergify/bp/v2.0/pr-2483

Conversation

@mergify
Copy link
Copy Markdown

@mergify mergify Bot commented Aug 8, 2024

Problem

When the Core BPF migration module was being added to the runtime, the executable flag for accounts was being deprecated, so checks for this flag were not added to the mechanisms for migrating and upgrading Core BPF programs. See #309.

These changes were reverted, and the Core BPF migration code must be aware of the executable flag on accounts.

Additionally, even though the program can still be invoked via instruction, the program account must be set as executable when performing a migration, to ensure all executable flag checks are successful on the new program.

Summary of Changes

Two small changes:

#2483)

* Runtime: Core BPF: check `executable` on program load

* Runtime: Core BPF: set `executable` on migration

(cherry picked from commit 33119c5)
@mergify mergify Bot requested a review from a team as a code owner August 8, 2024 22:27
@buffalojoec
Copy link
Copy Markdown

Requesting backport to 2.0 to ensure any upcoming feature gates to migrate programs will allow those programs to have the executable flag set to the expected value post-migration. Note: These feature gates are not yet scheduled.

@buffalojoec buffalojoec requested a review from 2501babe August 13, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants