Skip to content

Bump rbpf version to 0.8.5 #2515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 1 commit into from
Aug 8, 2024
Merged

Bump rbpf version to 0.8.5 #2515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Copy link
Copy Markdown

@PhilEngel PhilEngel Sep 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stuggling with an error, any advice would be greatly appreciated: error: failed to select a version for the requirement solana_rbpf = "=0.8.0"
candidate versions found which didn't match: 0.8.5, 0.8.4, 0.8.3, ...
location searched: crates.io index
required by package solana-program-test v1.17.23
The cargo.toml -
[dependencies]
anchor-lang = "0.28.0"
solana-program = "1.16.0"
anchor-spl = "0.28.0"
scroll = "0.12.0"
solana_rbpf = "=0.8.5"

[dev-dependencies]
solana-program-test = "=1.17.23"
solana-sdk = "1.16.0"

Copy link
Copy Markdown

@Lichtso Lichtso Sep 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We yanked v0.8.0 from crates.io as it contained a security flaw.

Copy link
Copy Markdown
Author

@willhickey willhickey Sep 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1.17 isn't supported anymore... upgrading to the latest v1.18 version (currently v1.18.23) will resolve this.

If for some reason you need to use v1.17 then you'll need to update the solana_rbpf dependency. v0.8.3 is equivalent to v0.8.0, but with the security issue patched.

If this doesn't make sense let us know what you're trying to build and we can offer more specific guidance.

Copy link
Copy Markdown

@PhilEngel PhilEngel Sep 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all updates have been done but the error when running cargo update to "solana_rbpf = "=0.8.0" stays, other than changing the cargo.toml, what else needs to be done? (sorry a bit of a newbie..)

Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,7 @@ solana-zk-keygen = { path = "zk-keygen", version = "=2.1.0" }
solana-zk-sdk = { path = "zk-sdk", version = "=2.1.0" }
solana-zk-token-proof-program = { path = "programs/zk-token-proof", version = "=2.1.0" }
solana-zk-token-sdk = { path = "zk-token-sdk", version = "=2.1.0" }
solana_rbpf = "=0.8.2"
solana_rbpf = "=0.8.5"
spl-associated-token-account = "=4.0.0"
spl-instruction-padding = "0.2"
spl-memo = "=5.0.0"
Expand Down
4 changes: 2 additions & 2 deletions programs/sbf/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion programs/sbf/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ solana-transaction-status = { path = "../../transaction-status", version = "=2.1
solana-type-overrides = { path = "../../type-overrides", version = "=2.1.0" }
agave-validator = { path = "../../validator", version = "=2.1.0" }
solana-zk-token-sdk = { path = "../../zk-token-sdk", version = "=2.1.0" }
solana_rbpf = "=0.8.2"
solana_rbpf = "=0.8.5"
thiserror = "1.0"

[package]
Expand Down