ci: trigger macos clippy after linux check passed#244
Closed
yihau wants to merge 3 commits intoanza-xyz:masterfrom
Closed
ci: trigger macos clippy after linux check passed#244yihau wants to merge 3 commits intoanza-xyz:masterfrom
yihau wants to merge 3 commits intoanza-xyz:masterfrom
Conversation
yihau
force-pushed
the
trigger-macos-clippy-by-buildkite
branch
2 times, most recently
from
32cd8ff to
1edde1a
Compare
yihau
force-pushed
the
trigger-macos-clippy-by-buildkite
branch
from
1edde1a to
ae13e45
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #244 +/- ##
=======================================
Coverage 81.9% 81.9%
=======================================
Files 836 836
Lines 226643 226643
=======================================
+ Hits 185636 185664 +28
+ Misses 41007 40979 -28 |
Member
Author
|
it looks like: when this one get merged, we will only trigger macos clippy when linux check are all green (it will fail in this PR due to we haven't had this pipeline) |
OliverNChalk
pushed a commit
to OliverNChalk/agave
that referenced
this pull request
Nov 11, 2025
|
This pull request is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We use large runners for
macos clippy. would like to have another process for saving money. 💸Summary of Changes
call
macos clippyafter linux check.(--fail-with-body is added in 7.76.0 😞 so I use --fail instead)