v1.18: ledger-tool: Set initial last full snapshot slot (backport of #2314)#2342
Merged
brooksprumo merged 1 commit intov1.18from Jul 31, 2024
Merged
v1.18: ledger-tool: Set initial last full snapshot slot (backport of #2314)#2342brooksprumo merged 1 commit intov1.18from
brooksprumo merged 1 commit intov1.18from
Conversation
(cherry picked from commit 75a640e)
CriesofCarrots
approved these changes
Jul 30, 2024
willhickey
approved these changes
Jul 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ledger-tool does not set the initial last full snapshot slot for AccountBackgroundService. This could produce invalid incremental snapshots. Ones that are missing zero lamport accounts. In the full snapshot these accounts would still have non-zero lamports, and thus would be resurrected on startup. This is bad.
Summary of Changes
Set the initial last full snapshot slot.
A useful additional piece of info: #2314 (comment)
This is an automatic backport of pull request #2314 done by [Mergify](https://mergify.com).