Skip to content

[solana-install-init] Optimize error message for Windows user permission installation #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joncinque merged 4 commits into from
Mar 18, 2024
Merged

[solana-install-init] Optimize error message for Windows user permission installation #234

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d9605d3
feat: check user's permissions in Windows
WGB5445 Mar 14, 2024
09eacc9
feat: Remove check fun and check os_err
WGB5445 Mar 15, 2024
b3259b4
Merge branch 'anza-xyz:master' into patch1
WGB5445 Mar 16, 2024
cb7fc57
fmt and optimize code
WGB5445 Mar 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions install/src/command.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1171,13 +1171,17 @@ pub fn init_or_update(config_file: &str, is_init: bool, check_only: bool) -> Res
release_dir.join("solana-release"),
config.active_release_dir(),
)
.map_err(|err| {
format!(
.map_err(|err| match err.raw_os_error() {
#[cfg(windows)]
Some(os_err) if os_err == winapi::shared::winerror::ERROR_PRIVILEGE_NOT_HELD => {
"You need to run this command with administrator privileges.".to_string()
}
_ => format!(
"Unable to symlink {:?} to {:?}: {}",
release_dir,
config.active_release_dir(),
err
)
),
})?;

config.save(config_file)?;
Expand Down