Skip to content

SIMD#83 - Allow conflicting entries on replay side#2256

Closed
Huzaifa696 wants to merge 7 commits intoanza-xyz:masterfrom
rakurai-io:allow-conlficting-entries-in-replay
Closed

SIMD#83 - Allow conflicting entries on replay side#2256
Huzaifa696 wants to merge 7 commits intoanza-xyz:masterfrom
rakurai-io:allow-conlficting-entries-in-replay

Conversation

@Huzaifa696
Copy link
Copy Markdown

@Huzaifa696 Huzaifa696 commented Jul 23, 2024

Problem

Currently self-conflicting batches are not allowed on the replay side whereas SIMD#83 requires this support.

Summary of Changes

  • Introduced a flag in every batch to distinguish between self-conflicting and disjoint batches
  • Bypass rebatching for self-conflicting batches (for now)

Related to:
#1025

@mergify mergify Bot requested a review from a team July 23, 2024 16:58
@Huzaifa696
Copy link
Copy Markdown
Author

Huzaifa696 commented Jul 23, 2024

This PR is currently a WIP.
It's complete in terms of code changes to support self-conflicting batches in rebatch_and_execute_batches (old flow). Our initial testing shows that schedule_batches_for_execution (new flow) is supporting self-conflicting batches.

We are currently working on testcases and benchmarking. Pushed a little in advance to get your feedback.

@Huzaifa696 Huzaifa696 force-pushed the allow-conlficting-entries-in-replay branch 2 times, most recently from 75448e4 to 7e7d882 Compare July 24, 2024 11:17
@Huzaifa696
Copy link
Copy Markdown
Author

Huzaifa696 commented Jul 24, 2024

Incorporated unit tests for rebatching logic in rebatch_and_execute_batches to ensure self-conflicting batches are not rebatched. Also added a unit test for schedule_batches_for_execution (new flow) for self-conflicting batches and it seems to handle this case.

After SVM changes (to allow self-conflicting batches), further tests can be added to test execution of self-conflicting batches in process_batches.

Is rebatching of self-conflicting batches required?

@Huzaifa696 Huzaifa696 marked this pull request as ready for review July 30, 2024 08:08
@Huzaifa696 Huzaifa696 force-pushed the allow-conlficting-entries-in-replay branch from 69a9e56 to c4f2199 Compare August 16, 2024 04:28
@Huzaifa696 Huzaifa696 force-pushed the allow-conlficting-entries-in-replay branch from c4f2199 to e0c31ac Compare August 30, 2024 12:58
@steviez
Copy link
Copy Markdown

steviez commented Nov 3, 2025

This PR is more than a year old and I believe the implementation has been completed elsewhere (SIMD 83 looks to be coming up on the testnet feature activation queue) so going to close this PR

@steviez steviez closed this Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants