replace solana-client with its constituent parts where possible#2086
Merged
CriesofCarrots merged 1 commit intoanza-xyz:masterfrom Jul 16, 2024
Merged
replace solana-client with its constituent parts where possible#2086CriesofCarrots merged 1 commit intoanza-xyz:masterfrom
CriesofCarrots merged 1 commit intoanza-xyz:masterfrom
Conversation
kevinheavey
force-pushed
the
less-solana-client
branch
from
1feaff8 to
20db2be
Compare
kevinheavey
force-pushed
the
less-solana-client
branch
from
20db2be to
a5de314
Compare
CriesofCarrots
approved these changes
Jul 16, 2024
CriesofCarrots
left a comment
CriesofCarrots
left a comment
There was a problem hiding this comment.
Too bad those solana-client re-exports weren't actually marked as deprecated. Would have been lovely to just rip them out in #1992
| @@ -36,6 +36,7 @@ solana-cli-output = { workspace = true } | |||
| solana-client = { workspace = true } | |||
There was a problem hiding this comment.
It would be nice if we could remove this dependency from solana-cli altogether. It's the send-transaction stuff in program that's preventing that?
Author
There was a problem hiding this comment.
that plus connection_cache I think
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
solana-client agglomerates multiple crates, so anywhere we can use the underlying crate instead of solana-client is a win for compile times, or at least gets us closer to removing solana-client from a particular crate
Summary of Changes
Replaces solana-client with underlying crates where possible. I was hoping there'd be more but this is something