v1.18: ci: ignore curve25519-dalek audit temporarily (backport of #1786)#1891
Closed
mergify[bot] wants to merge 2 commits intov1.18from
Closed
v1.18: ci: ignore curve25519-dalek audit temporarily (backport of #1786)#1891mergify[bot] wants to merge 2 commits intov1.18from
mergify[bot] wants to merge 2 commits intov1.18from
Conversation
Author
|
Cherry-pick of a6bc917 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
CriesofCarrots
approved these changes
Jun 27, 2024
|
I know we ignored the audit on master because we expect to perform the suggested version bump soon; however, it is not immediately obvious to me if ignoring the issue is safe on our v1.18 branch. @ryoqun - You reviewed the initial PR, do you have any insights on this? If not, I can do digging through to try to figure out what the appropriate action is for the v1.18 branch |
yihau
approved these changes
Jul 1, 2024
ci: ignore curve25519-dalek audit (cherry picked from commit a6bc917) # Conflicts: # ci/do-audit.sh
cf1f38b to
1c6a846
Compare
|
Closing this PR - we ended up getting this as part of #1939 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
audit failed

I had a PR for this one weeks ago, but it's still stuck in the SPL downstream project test. I will prioritize this one. Ignore this audit to unblock CI.
#1693
Summary of Changes
ignore the audit temporarily
This is an automatic backport of pull request #1786 done by Mergify.