v1.18: fix race condition on vote count (backport of #1762)#1838
Closed
mergify[bot] wants to merge 1 commit intov1.18from
Closed
v1.18: fix race condition on vote count (backport of #1762)#1838mergify[bot] wants to merge 1 commit intov1.18from
mergify[bot] wants to merge 1 commit intov1.18from
Conversation
(cherry picked from commit d06a3ac) # Conflicts: # core/src/banking_stage/latest_unprocessed_votes.rs
Author
|
Cherry-pick of d06a3ac has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
This was referenced Jun 24, 2024
|
Closing this as stale. If you think this is relevant please re-open and let |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
update_latest_votein updating the count.Example Timeline:
thread1: get_entry, doesn't exist.
thread2: insert's new entry. increments count.
thread1: overwrites entry. increments count.
Summary of Changes
Fixes #
This is an automatic backport of pull request #1762 done by [Mergify](https://mergify.com).