Skip to content

transaction-status: Use string instead of int for amount in amountToUiAmount #1737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joncinque merged 3 commits into from
Jun 18, 2024
Merged

transaction-status: Use string instead of int for amount in amountToUiAmount #1737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4fcc926
transaction-status: Use string instead of int for `amount`
joncinque Jun 13, 2024
49fe21c
Add a changelog entry
joncinque Jun 13, 2024
20e3d8a
Update CHANGELOG.md
joncinque Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ Release channels have their own copy of this changelog:
when the `replaceRecentBlockhash` config param is `true` (#380)
* SDK: `cargo test-sbf` accepts `--tools-version`, just like `build-sbf` (#1359)
* CLI: Can specify `--full-snapshot-archive-path` (#1631)
* transaction-status: The SPL Token `amountToUiAmount` instruction parses the amount into a string instead of a number (#1737)

## [1.18.0]
* Changes
Expand Down
4 changes: 2 additions & 2 deletions transaction-status/src/parse_token.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,7 +498,7 @@ pub fn parse_token(
instruction_type: "amountToUiAmount".to_string(),
info: json!({
"mint": account_keys[instruction.accounts[0] as usize].to_string(),
"amount": amount,
"amount": amount.to_string(),
}),
})
}
Expand Down Expand Up @@ -1737,7 +1737,7 @@ mod test {
instruction_type: "amountToUiAmount".to_string(),
info: json!({
"mint": mint_pubkey.to_string(),
"amount": 4242,
"amount": "4242",
})
}
);
Expand Down