v1.18: bench-tps: allow option to not set account data size on every transaction (backport of #209)#1714
Closed
mergify[bot] wants to merge 1 commit intov1.18from
Closed
v1.18: bench-tps: allow option to not set account data size on every transaction (backport of #209)#1714mergify[bot] wants to merge 1 commit intov1.18from
mergify[bot] wants to merge 1 commit intov1.18from
Conversation
|
Opening this backport to start the discussion on whether we should backport this to v1.18. I would call this low risk given the code is contained to bench-tps (and a couple of inputs in dos files). Without backporting this, users will not be able to run bench-tps built from v1.18 releases against frankendancer CC @anwayde |
|
Looks good to me |
CriesofCarrots
approved these changes
Jun 26, 2024
|
Closing this as stale. If you think this is relevant please re-open and let |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Bench TPS needs this feature activated on the cluster since all transactions are hardcoded to include the instruction to set the account data size. However, this will not work on a test cluster where this feature is not activated. Moreover, Firedancer currently does not support that instruction.
Summary of Changes
This adds a flag
--skip-tx-account-data-sizewhich when specified, will not add that instruction. This makes Bench TPS work with FIredancer (and Solana clusters without any features activated).Fixes #
This is an automatic backport of pull request #209 done by [Mergify](https://mergify.com).