Wire scheduler up to adjust actual loaded accounts size cost for committed transactions#1547
Merged
tao-stones merged 3 commits intoanza-xyz:masterfrom Jun 7, 2024
Conversation
…itted transactions
brooksprumo
reviewed
Jun 5, 2024
brooksprumo
left a comment
There was a problem hiding this comment.
I'm not familiar with this code, and I don't see anything obviously touching accounts-db. @tao-stones, is there a guidance on what you'd like me to look at?
Also, I see this PR does new stuff if a feature gate is active, but I don't see a new feature gate in this PR. That implies to me there's already an existing feature gate issue. Can you update the PR description to include the issue number and label (if you edit the PR description, you'll see them as comments at the bottom)? This will help me with the additional context. Thanks!
Author
My apology - meant to add @bw-solana to this PR |
bw-solana
reviewed
Jun 6, 2024
bw-solana
reviewed
Jun 6, 2024
ca3c4f7 to
cdde7a6
Compare
bw-solana
reviewed
Jun 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Transaction may set
loaded_accounts_data_sizelimit, or uses default limit, that is higher than it actually loads. When cost model starts to "charge"CUfor loaded accounts data size, it is necessary to adjust block space transaction reserved with accounts size it actually loaded, alone with "executed CU" adjustment.Summary of Changes
loaded_accounts_data_sizetoCommittedenum variance.loaded_accounts_data_size_costto cost_tracker adjustment logic inupdate_execution_cost()Note
Function of "charging CU for loaded accounts" logic is still behind
include_loaded_accounts_data_size_in_fee_calculationgate, therefore this PR does not change Scheduler behavior until #1356Fixes #