v1.18: add precompile signature metrics to cost tracker (backport of #133)#143
Merged
tao-stones merged 3 commits intov1.18from Mar 12, 2024
Merged
v1.18: add precompile signature metrics to cost tracker (backport of #133)#143tao-stones merged 3 commits intov1.18from
tao-stones merged 3 commits intov1.18from
Conversation
(cherry picked from commit 9770cd9)
willhickey
force-pushed
the
mergify/bp/v1.18/pr-133
branch
from
1ae87a2 to
07fff86
Compare
jstarry
approved these changes
Mar 12, 2024
anwayde
pushed a commit
to firedancer-io/agave
that referenced
this pull request
Jul 23, 2024
…nza-xyz#133) (anza-xyz#143) * add precompile signature metrics to cost tracker (anza-xyz#133) (cherry picked from commit 9770cd9) * merge fix * fmt --------- Co-authored-by: Tao Zhu <82401714+tao-stones@users.noreply.github.com> Co-authored-by: Tao Zhu <tao@solana.com>
OliverNChalk
pushed a commit
to OliverNChalk/agave
that referenced
this pull request
Nov 11, 2025
With the current implementation, it is not straightforward to write unit tests
for CLI of invalidator-client.
Summary of Changes
1. Extract `build_args` function, which can be used for testing purposes.
2. to prevent compilation errors, use `formatcp` instead of `format` in help.
3. Use `strum` instead of `enum_iter`:
* It is wider used in the repo (cli_names function in validator).
* The code is simpler with serde.
* For an enum with composite variants `strum` is simpler to use (this is in
the next pr).
* Having `strum` for CLI and `serde` for RPC will allow to use kebab-style for
CLI and camel for RPC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #133 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com