Skip to content

v1.17: add precompile signature metrics to cost tracker (backport of #133)#142

Merged
tao-stones merged 3 commits intov1.17from
mergify/bp/v1.17/pr-133
Mar 13, 2024
Merged

v1.17: add precompile signature metrics to cost tracker (backport of #133)#142
tao-stones merged 3 commits intov1.17from
mergify/bp/v1.17/pr-133

Conversation

@mergify
Copy link
Copy Markdown

@mergify mergify Bot commented Mar 8, 2024

This is an automatic backport of pull request #133 done by Mergify.
Cherry-pick of 9770cd9 has failed:

On branch mergify/bp/v1.17/pr-133
Your branch is up to date with 'origin/v1.17'.

You are currently cherry-picking commit 9770cd9083.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   cost-model/src/block_cost_limits.rs
	modified:   cost-model/src/transaction_cost.rs
	modified:   sdk/program/src/message/sanitized.rs

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   cost-model/src/cost_model.rs
	both modified:   cost-model/src/cost_tracker.rs

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

(cherry picked from commit 9770cd9)

# Conflicts:
#	cost-model/src/cost_model.rs
#	cost-model/src/cost_tracker.rs
@mergify mergify Bot added the conflicts label Mar 8, 2024
@mergify
Copy link
Copy Markdown
Author

mergify Bot commented Mar 8, 2024

Cherry-pick of 9770cd9 has failed:

On branch mergify/bp/v1.17/pr-133
Your branch is up to date with 'origin/v1.17'.

You are currently cherry-picking commit 9770cd9083.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   cost-model/src/block_cost_limits.rs
	modified:   cost-model/src/transaction_cost.rs
	modified:   sdk/program/src/message/sanitized.rs

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   cost-model/src/cost_model.rs
	both modified:   cost-model/src/cost_tracker.rs

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 8, 2024

Codecov Report

❌ Patch coverage is 96.49123% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.6%. Comparing base (0ef1f65) to head (685dfbf).
⚠️ Report is 48 commits behind head on v1.17.

Additional details and impacted files
@@            Coverage Diff            @@
##            v1.17     #142     +/-   ##
=========================================
- Coverage    81.6%    81.6%   -0.1%     
=========================================
  Files         806      806             
  Lines      219092   219195    +103     
=========================================
+ Hits       178883   178965     +82     
- Misses      40209    40230     +21     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tao-stones tao-stones requested review from jstarry and t-nelson March 12, 2024 14:04
@tao-stones tao-stones merged commit 2332aee into v1.17 Mar 13, 2024
@tao-stones tao-stones deleted the mergify/bp/v1.17/pr-133 branch March 13, 2024 01:47
@HaoranYi HaoranYi mentioned this pull request Apr 8, 2024
OliverNChalk pushed a commit to OliverNChalk/agave that referenced this pull request Nov 11, 2025
* minor refactoring of write program generator

* add unit test for write program generator

* fix typo

* Add configuration to WriteGenerator

* rename num_batch to num_generator_exec

* address clippy errors

* Update Cargo.lock

* Introduce struct instead of unnamed enum variant to define default

* fix typo in comment

* improve error messages and comments

* fix failing test

* Update code after rebase with upstream

* address PR review comments

* fix clippy errors

* fix problem with rpc replay call validation

* change the way payers are rotated

* address minor PR comments

* address PR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants