Skip to content

add loaded-account-data-size-cost to qos metric#1369

Merged
tao-stones merged 1 commit intoanza-xyz:masterfrom
tao-stones:imp-add-loaded-accounts-data-size-cost-to-metric
May 15, 2024
Merged

add loaded-account-data-size-cost to qos metric#1369
tao-stones merged 1 commit intoanza-xyz:masterfrom
tao-stones:imp-add-loaded-accounts-data-size-cost-to-metric

Conversation

@tao-stones
Copy link
Copy Markdown

Problem

loaded_accounts_data_size_cost are not reported to metric.

Summary of Changes

  • add it to qos metric table

Fixes #

@tao-stones tao-stones requested review from apfitzge and bw-solana May 15, 2024 15:07
Copy link
Copy Markdown

@bw-solana bw-solana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bw-solana
Copy link
Copy Markdown

backport to v1.18?

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 15, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.1%. Comparing base (aa2f078) to head (cf79b71).
⚠️ Report is 6578 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #1369     +/-   ##
=========================================
- Coverage    82.1%    82.1%   -0.1%     
=========================================
  Files         886      886             
  Lines      236417   236431     +14     
=========================================
- Hits       194266   194237     -29     
- Misses      42151    42194     +43     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tao-stones
Copy link
Copy Markdown
Author

backport to v1.18?

It'd report 0 until #1356 is merged/bp-ed. Maybe backport after #1356?

@tao-stones tao-stones merged commit e86ab5a into anza-xyz:master May 15, 2024
@tao-stones tao-stones deleted the imp-add-loaded-accounts-data-size-cost-to-metric branch May 15, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants