Use tls-zeroed-aligned-memory

[ryoqun]

as part of eval of mimalloc (#1250 )

Problem

Perf result

all cases are measured with --block-verification-method=blockstore-processor

jemalloc

ledger processed in 24 seconds, 848 ms
ledger processed in 24 seconds, 842 ms
ledger processed in 24 seconds, 801 ms

mimalloc

ledger processed in 25 seconds, 666 ms
ledger processed in 25 seconds, 174 ms
ledger processed in 25 seconds, 77 ms

glibc

ledger processed in 24 seconds, 908 ms
ledger processed in 24 seconds, 827 ms
ledger processed in 24 seconds, 974 ms

rpmalloc

ledger processed in 24 seconds, 783 ms
ledger processed in 24 seconds, 977 ms
ledger processed in 25 seconds, 256 ms

... so, the conclusion is that all allocators are similar in terms of replay speed...

Summary of Changes

xref: solana-labs/rbpf#565

Fixes solana-labs#27275

[alessandrod]

I ended up doing exactly the same thing (a buffer pool), after my 0-filled tmpfs remap didn't work in the validator, from last week's standup:

integrated my alternative vm stack allocation impl in the validator and... it failed spectacularly. The trick I was using was to remap a 0-page in a new mapping (create a 0 filled tmpfs file, remap it over and over to allocate zeroed memory). That works great if you allocate from a relatively low number of threads. I discovered it breaks horribly if you allocate from a bazillion threads (like the validator does), because linux uses a rwlock on current->vm (the tree used to track vmas), and if you mmap from multiple threads that lock becomes write contended. So I begrudgingly scrapped that and implemented a thread-local buffer pool instead (not Recycler because that uses a lock), which seems to work, but needs some more love.

😅

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.8%. Comparing base (f54c120) to head (20e012f).
Report is 3 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1364   +/-   ##
=======================================
  Coverage    82.8%    82.8%           
=======================================
  Files         872      872           
  Lines      369252   369291   +39     
=======================================
+ Hits       305797   305867   +70     
+ Misses      63455    63424   -31     

[github-actions]

This pull request is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[github-actions]

This pull request was closed because it has been stale for 7 days with no activity.