Conversation
) (cherry picked from commit b5c5bd3)
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## v1.18 #1279 +/- ##
=========================================
- Coverage 81.6% 81.6% -0.1%
=========================================
Files 827 827
Lines 225421 225430 +9
=========================================
+ Hits 184095 184100 +5
- Misses 41326 41330 +4 🚀 New features to boost your workflow:
|
steviez
approved these changes
May 10, 2024
steviez
left a comment
steviez
left a comment
There was a problem hiding this comment.
I'm in favor of this change for BP - this PR is demoting several panics to error logs in the name of being cautious. No functional changes and again, just being VERY cautious for a situation that should never occur given other system parameters
behzadnouri
approved these changes
May 10, 2024
CriesofCarrots
approved these changes
May 10, 2024
yihau
approved these changes
May 10, 2024
anwayde
pushed a commit
to firedancer-io/agave
that referenced
this pull request
Jul 23, 2024
…ion (backport of anza-xyz#1259) (anza-xyz#1279) blockstore: account for blockstore cleanup during shred insertion (anza-xyz#1259) (cherry picked from commit b5c5bd3) Co-authored-by: Ashwin Sekar <ashwin@anza.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v1.18 introduces many new
expectandunwraps on blockstore invariants.An audit shows that some of these invariants might not hold under extreme situations. Specifically any check relying on receiving a shred from
get_shred_from_just_inserted_or_dbmay fail if the slot is cleaned up during shred insertion:Sis received and compared successfully againstblockstore.max_root()in shred fetch stageblockstore.max_root()pastSblockstore.max_root(), including the columns for the shred currently being inserted (insertion lock is not checked here)get_shred_from_just_inserted_or_dbis no longer present.(4) is unlikely to happen as @steviez pointed out here #1151 (comment), but for safety this should still be accounted for.
This is an automatic backport of pull request #1259 done by Mergify.