Check current channel version according to updated release procedures#12648
Conversation
During new release procedures we bump the version and tag the new release at exactly the same time. Therefore the version of the branch should match the latest tag.
|
Backports to release branches are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
|
do we need the check at all now? it doesn't matter when stuff goes in around the version bump now because we have the exact commit. this check was intended to prevent the following situation afaict there is no similar situation now. we're releasing directly from the tag now rather than the tip of a branch |
I'm always happy to delete some code: #12662 |
|
Closing in favor of #12662 |
Problem
During new release procedures we bump the version and tag the new release at exactly the same time. Therefore the version of the branch should match the latest tag.
Summary of Changes
Reverse the condition.