Skip to content

Check current channel version according to updated release procedures#12648

Closed
levsha wants to merge 1 commit into
anza-xyz:masterfrom
levsha:levsha/Check-current-channel-version-according-to-updated-release-procedures
Closed

Check current channel version according to updated release procedures#12648
levsha wants to merge 1 commit into
anza-xyz:masterfrom
levsha:levsha/Check-current-channel-version-according-to-updated-release-procedures

Conversation

@levsha
Copy link
Copy Markdown

@levsha levsha commented May 21, 2026

Problem

During new release procedures we bump the version and tag the new release at exactly the same time. Therefore the version of the branch should match the latest tag.

Summary of Changes

Reverse the condition.

During new release procedures we bump the version and tag the new release at exactly the same time. Therefore the version of the branch should match the latest tag.
@levsha levsha marked this pull request as ready for review May 21, 2026 07:28
@levsha levsha requested a review from a team May 21, 2026 07:28
@levsha levsha added v4.0 Backport to v4.0 branch v4.1 Backport to v4.1 branch labels May 21, 2026
@mergify
Copy link
Copy Markdown

mergify Bot commented May 21, 2026

Backports to release branches are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

@t-nelson
Copy link
Copy Markdown

do we need the check at all now? it doesn't matter when stuff goes in around the version bump now because we have the exact commit. this check was intended to prevent the following situation

* ...                  # correct version
* feature commit       # correct version
* release commit       # correct version
* feature commit       # wrong version
* ...                  # wrong version
* version bump commit  # correct version

afaict there is no similar situation now. we're releasing directly from the tag now rather than the tip of a branch

@levsha
Copy link
Copy Markdown
Author

levsha commented May 21, 2026

do we need the check at all now? it doesn't matter when stuff goes in around the version bump now because we have the exact commit.

I'm always happy to delete some code: #12662

@levsha
Copy link
Copy Markdown
Author

levsha commented May 21, 2026

Closing in favor of #12662

@levsha levsha closed this May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v4.0 Backport to v4.0 branch v4.1 Backport to v4.1 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants