blockstore_processor: set block id for bank 0#12353
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #12353 +/- ##
=========================================
- Coverage 83.2% 83.2% -0.1%
=========================================
Files 849 849
Lines 322519 322523 +4
=========================================
- Hits 268527 268526 -1
- Misses 53992 53997 +5 🚀 New features to boost your workflow:
|
bw-solana
approved these changes
May 7, 2026
steviez
approved these changes
May 7, 2026
| bank0.set_block_id(Some( | ||
| blockstore | ||
| .get_block_id(bank0.slot(), migration_status)? | ||
| .expect("block id for a full slot must exist"), |
There was a problem hiding this comment.
I typically prefer error propagation but am fine with the expect() here given that:
confirm_full_slot()will fail if slot 0 is not full- We do want to confirm it is a
Some(_)instead of passing aNonethrough and hiding the issue
That is, the slot will have to have been made not full between now and confirm_full_slot() (the function call above) in order for this to fail
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The genesis bank did not have it's block id set.
Summary of Changes
Set it