Skip to content

blockstore_processor: set block id for bank 0#12353

Merged
AshwinSekar merged 1 commit into
anza-xyz:masterfrom
AshwinSekar:bid-0
May 7, 2026
Merged

blockstore_processor: set block id for bank 0#12353
AshwinSekar merged 1 commit into
anza-xyz:masterfrom
AshwinSekar:bid-0

Conversation

@AshwinSekar
Copy link
Copy Markdown

Problem

The genesis bank did not have it's block id set.

Summary of Changes

Set it

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.2%. Comparing base (b6abf60) to head (7d27410).

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #12353     +/-   ##
=========================================
- Coverage    83.2%    83.2%   -0.1%     
=========================================
  Files         849      849             
  Lines      322519   322523      +4     
=========================================
- Hits       268527   268526      -1     
- Misses      53992    53997      +5     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

bank0.set_block_id(Some(
blockstore
.get_block_id(bank0.slot(), migration_status)?
.expect("block id for a full slot must exist"),
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I typically prefer error propagation but am fine with the expect() here given that:

  • confirm_full_slot() will fail if slot 0 is not full
  • We do want to confirm it is a Some(_) instead of passing a None through and hiding the issue

That is, the slot will have to have been made not full between now and confirm_full_slot() (the function call above) in order for this to fail

@AshwinSekar AshwinSekar added this pull request to the merge queue May 7, 2026
Merged via the queue into anza-xyz:master with commit e25cdff May 7, 2026
48 checks passed
@AshwinSekar AshwinSekar deleted the bid-0 branch May 7, 2026 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants