v4.0: rpc: Fix short-circuit condition going into big-table (backport of #12068)#12167
Merged
Conversation
#### Problem While updating the bigtable fallback logic in #7937, we incorrectly short-circuited the check into bigtable. Currently, we always go into bigtable if `until` is not specified, even if we've hit the limit of transactions to return. #### Summary of changes Only respect `found_until` if `until` is provided. (cherry picked from commit 1a36fe0)
Author
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## v4.0 #12167 +/- ##
=========================================
- Coverage 82.9% 82.9% -0.1%
=========================================
Files 842 842
Lines 317881 317881
=========================================
- Hits 263793 263750 -43
- Misses 54088 54131 +43 🚀 New features to boost your workflow:
|
t-nelson
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
While updating the bigtable fallback logic in #7937, we incorrectly short-circuited the check into bigtable. Currently, we always go into bigtable if
untilis not specified, even if we've hit the limit of transactions to return.Summary of changes
Only respect
found_untilifuntilis provided.This is an automatic backport of pull request #12068 done by Mergify.