Skip to content

v4.0: rpc: Fix short-circuit condition going into big-table (backport of #12068)#12167

Merged
steviez merged 1 commit into
v4.0from
mergify/bp/v4.0/pr-12068
Apr 24, 2026
Merged

v4.0: rpc: Fix short-circuit condition going into big-table (backport of #12068)#12167
steviez merged 1 commit into
v4.0from
mergify/bp/v4.0/pr-12068

Conversation

@mergify
Copy link
Copy Markdown

@mergify mergify Bot commented Apr 24, 2026

Problem

While updating the bigtable fallback logic in #7937, we incorrectly short-circuited the check into bigtable. Currently, we always go into bigtable if until is not specified, even if we've hit the limit of transactions to return.

Summary of changes

Only respect found_until if until is provided.


This is an automatic backport of pull request #12068 done by Mergify.

#### Problem

While updating the bigtable fallback logic in #7937, we incorrectly
short-circuited the check into bigtable. Currently, we always go into
bigtable if `until` is not specified, even if we've hit the limit of
transactions to return.

#### Summary of changes

Only respect `found_until` if `until` is provided.

(cherry picked from commit 1a36fe0)
@mergify mergify Bot requested a review from a team as a code owner April 24, 2026 08:04
@mergify
Copy link
Copy Markdown
Author

mergify Bot commented Apr 24, 2026

If this PR represents a change to the public RPC API:

  1. Make sure it includes a complementary update to rpc-client/ (example)
  2. Open a follow-up PR to update the JavaScript client @solana/kit (example)

Thank you for keeping the RPC clients in sync with the server API @mergify[bot].

Copy link
Copy Markdown

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as SME

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.9%. Comparing base (024f40a) to head (8955248).

Additional details and impacted files
@@            Coverage Diff            @@
##             v4.0   #12167     +/-   ##
=========================================
- Coverage    82.9%    82.9%   -0.1%     
=========================================
  Files         842      842             
  Lines      317881   317881             
=========================================
- Hits       263793   263750     -43     
- Misses      54088    54131     +43     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@steviez steviez merged commit d423dae into v4.0 Apr 24, 2026
51 checks passed
@steviez steviez deleted the mergify/bp/v4.0/pr-12068 branch April 24, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants