v1.18: Remove the chained merkle root check#1161
Closed
AshwinSekar wants to merge 1 commit intoanza-xyz:v1.18from
Closed
v1.18: Remove the chained merkle root check#1161AshwinSekar wants to merge 1 commit intoanza-xyz:v1.18from
AshwinSekar wants to merge 1 commit intoanza-xyz:v1.18from
Conversation
AshwinSekar
changed the title
This is a partial revert of 07a9b53
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v1.18 #1161 +/- ##
=========================================
- Coverage 81.6% 81.5% -0.2%
=========================================
Files 827 827
Lines 225352 225332 -20
=========================================
- Hits 184011 183704 -307
- Misses 41341 41628 +287 |
Author
|
closed in favor of #1163 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a partial revert of commit 07a9b53.
The original commit does not account for the fact that the validator can upgrade with incomplete shreds in a slot.
If the upgrade happens around an FEC set boundary, checking the previous merkle root chaining should not assume the merkle root meta column exists for the previous FEC set.