adds api to obtain the parent node in the turbine retransmit tree #115
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #115 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 838 838
Lines 225947 225998 +51
=========================================
- Hits 184971 184966 -5
- Misses 40976 41032 +56 |
behzadnouri
force-pushed
the
get-retransmit-parent
branch
2 times, most recently
from
73d9dac
to
4be7123
Compare
| @@ -589,10 +644,36 @@ mod tests { | |||
| } | |||
| } | |||
|
|
|||
| fn check_retransmit_nodes(fanout: usize, nodes: &[usize], peers: Vec<Vec<usize>>) { | |||
| let index: HashMap<_, _> = nodes | |||
There was a problem hiding this comment.
might be helpful to name this something like node_to_turbine_index
There was a problem hiding this comment.
Seems like we could have separate tests for (1) verifying the indices returned by get_retransmit_peers against expected indices and (2) verifying parent --> child --> parent translations are working. If we trust 1, we should be able to generically sweep across different degrees of fanout and numbers of nodes fairly easily
Following commits will use this api to check retransmitter's signature on incoming shreds.
behzadnouri
force-pushed
the
get-retransmit-parent
branch
from
4be7123
to
345348c
Compare
added a round trip test to verify the two function invert each other. |
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
Following commits will use this api to check retransmitter's signature on incoming shreds. (cherry picked from commit 42e8309)
…ree (backport of #115) (#135) adds api to obtain the parent node in the turbine retransmit tree (#115) Following commits will use this api to check retransmitter's signature on incoming shreds. (cherry picked from commit 42e8309) Co-authored-by: behzad nouri <[email protected]>
…ree (backport of anza-xyz#115) (anza-xyz#135) adds api to obtain the parent node in the turbine retransmit tree (anza-xyz#115) Following commits will use this api to check retransmitter's signature on incoming shreds. (cherry picked from commit 42e8309) Co-authored-by: behzad nouri <[email protected]>
…za-xyz#115) Following commits will use this api to check retransmitter's signature on incoming shreds.
Problem
Lock down turbine propagation tree.
Summary of Changes
Following commits will use this api to check retransmitter's signature on incoming shreds