v4.0: fix(fs): align write size to 4096 to support all NVMEs (backport of #11335)#11424
Merged
Conversation
(cherry picked from commit 504d2ca)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v4.0 #11424 +/- ##
=======================================
Coverage 83.0% 83.0%
=======================================
Files 838 838
Lines 316433 316433
=======================================
+ Hits 262803 262806 +3
+ Misses 53630 53627 -3 🚀 New features to boost your workflow:
|
alessandrod
approved these changes
Mar 20, 2026
steviez
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#9856 ended up with 512 alignment for direct I/O writes, but it fails for some NVMEs. As reported in FD tests:
The used hardware spec:
indicates the NVME sector size of 4KiB, which ends up as required alignment for
O_DIRECTindependently there were failures noticed on some CI workers where disks are
Again:
LOG-SECcolumn showing 4096 makes it match the same cause and bumping alignment to 4096 is confirmed to fix the issue there.Summary of Changes
Bump constant used for alignment of writes to
4096and update comment.This is an automatic backport of pull request #11335 done by [Mergify](https://mergify.com).