Gossip: fix time-based tiebreak in test_refresh_vote_eviction#11351
Merged
alexpyattaev merged 1 commit intoanza-xyz:masterfrom Mar 17, 2026
Merged
Conversation
alexpyattaev
commented
Mar 17, 2026
| let mut first_vote = None; | ||
| let mut prev_votes = vec![]; | ||
| for slot in 1..max_vote_slot { | ||
| for slot in lowest_vote_slot..max_vote_slot { |
Author
There was a problem hiding this comment.
changed to lowest_vote_slot to match what the variable is actually set to a few lines above.
AshwinSekar
approved these changes
Mar 17, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #11351 +/- ##
=======================================
Coverage 83.2% 83.2%
=======================================
Files 841 841
Lines 318444 318446 +2
=======================================
+ Hits 265125 265138 +13
+ Misses 53319 53308 -11 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Summary of Changes
Context:
https://discord.com/channels/428295358100013066/560503042458517505/1483166748491518014