Skip to content

Remove slow timeout override for test_bank_forks_new_rw_arc_memory_leak#11139

Merged
roryharr merged 1 commit intoanza-xyz:masterfrom
roryharr:remove_slow_timeout_override
Mar 12, 2026
Merged

Remove slow timeout override for test_bank_forks_new_rw_arc_memory_leak#11139
roryharr merged 1 commit intoanza-xyz:masterfrom
roryharr:remove_slow_timeout_override

Conversation

@roryharr
Copy link
Copy Markdown

@roryharr roryharr commented Mar 9, 2026 •
edited
Loading

Problem

test_bank_forks_new_rw_arc_memory_leak has a slow test override that it doesn't need

Summary of Changes

  • Remove it

Test was fixed in #8585

running 1 test
test bank_forks::tests::test_bank_forks_new_rw_arc_memory_leak ... ok
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 618 filtered out; finished in 0.12s

Fixes #

@roryharr roryharr requested a review from yihau March 9, 2026 23:31
@roryharr roryharr marked this pull request as ready for review March 9, 2026 23:31
yihau
yihau previously approved these changes Mar 10, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@yihau yihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@roryharr roryharr force-pushed the remove_slow_timeout_override branch from 505067d to 9903d7c Compare March 10, 2026 16:22
@roryharr
Copy link
Copy Markdown
Author

roryharr commented Mar 10, 2026

Had to rebase

@roryharr roryharr requested a review from yihau March 10, 2026 17:04
@roryharr
Copy link
Copy Markdown
Author

roryharr commented Mar 11, 2026

@yihau : ping

yihau
yihau approved these changes Mar 12, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@yihau yihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the very late response 🫠

@roryharr roryharr added this pull request to the merge queue Mar 12, 2026
Merged via the queue into anza-xyz:master with commit a47ebb6 Mar 12, 2026
38 checks passed
@roryharr roryharr deleted the remove_slow_timeout_override branch March 12, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yihau yihau yihau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@roryharr @yihau