v1.18: support Pubkey::to_bytes as constexpr (backport of #220)#1107
Merged
v1.18: support Pubkey::to_bytes as constexpr (backport of #220)#1107
Conversation
(cherry picked from commit 9b16df2)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v1.18 #1107 +/- ##
=======================================
Coverage 81.6% 81.6%
=======================================
Files 827 827
Lines 225352 225352
=======================================
+ Hits 184011 184022 +11
+ Misses 41341 41330 -11 |
t-nelson
approved these changes
May 2, 2024
steviez
approved these changes
May 2, 2024
steviez
left a comment
steviez
left a comment
There was a problem hiding this comment.
Was a little surprised we marked this one for BP, but very small / low risk change so I'm ok with it
CriesofCarrots
approved these changes
May 2, 2024
anwayde
pushed a commit
to firedancer-io/agave
that referenced
this pull request
Jul 23, 2024
… (anza-xyz#1107) sdk: support Pubkey::to_bytes as constexpr (anza-xyz#220) (cherry picked from commit 9b16df2) Co-authored-by: ripatel-fd <ripatel+git@jumptrading.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Cannot do compile-time tricks with static const pubkeys
Summary of Changes
Adds support for constexprs
Fixes #
This is an automatic backport of pull request #220 done by [Mergify](https://mergify.com).