Skip to content

Add support for partial tx batch unlocking#110

Merged
mergify[bot] merged 4 commits intoanza-xyz:masterfrom
jstarry:feat/partial-batch-unlock
Mar 7, 2024
Merged

Add support for partial tx batch unlocking#110
mergify[bot] merged 4 commits intoanza-xyz:masterfrom
jstarry:feat/partial-batch-unlock

Conversation

@jstarry
Copy link
Copy Markdown

@jstarry jstarry commented Mar 6, 2024

Problem

There's no way to partially unlock a batch of transactions (needed for fixing solana-labs#34825)

Summary of Changes

  • Added method to TransactionBatch for updating lock_results which unlocks any accounts that are no longer eligible for execution

Fixes #

@jstarry jstarry force-pushed the feat/partial-batch-unlock branch 2 times, most recently from 4aa4f23 to 853c670 Compare March 6, 2024 15:43
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 96.36364% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 81.8%. Comparing base (ce34f3f) to head (853c670).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #110   +/-   ##
=======================================
  Coverage    81.8%    81.8%           
=======================================
  Files         838      838           
  Lines      225941   225974   +33     
=======================================
+ Hits       184945   184983   +38     
+ Misses      40996    40991    -5     

@jstarry jstarry force-pushed the feat/partial-batch-unlock branch from 853c670 to a3dfc60 Compare March 7, 2024 02:00
@jstarry jstarry requested review from apfitzge and tao-stones March 7, 2024 02:00
Comment thread runtime/src/transaction_batch.rs
@jstarry jstarry added the automerge automerge Merge this Pull Request automatically once CI passes label Mar 7, 2024
@mergify mergify Bot merged commit adefcbb into anza-xyz:master Mar 7, 2024
@jstarry jstarry deleted the feat/partial-batch-unlock branch March 7, 2024 07:12
codebender828 pushed a commit to codebender828/agave that referenced this pull request Oct 3, 2024
* Add support for partial tx batch unlocking

* add assert

* fix build

* Add comments
OliverNChalk pushed a commit to OliverNChalk/agave that referenced this pull request Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge automerge Merge this Pull Request automatically once CI passes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants