v4.0: fix(fs): handle reads for file with zero size / limit (backport of #10900)#10927
Merged
Conversation
(cherry picked from commit 70a3438)
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## v4.0 #10927 +/- ##
===========================================
- Coverage 83.0% 68.6% -14.5%
===========================================
Files 836 747 -89
Lines 316338 215278 -101060
===========================================
- Hits 262659 147724 -114935
- Misses 53679 67554 +13875 🚀 New features to boost your workflow:
|
t-nelson
approved these changes
Mar 4, 2026
brooksprumo
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Files with 0 size or set to be read with limit 0 are not handled properly by
SequentialFileReader.This bug was introduced by #9701, which:
Summary of Changes
The fix covers two areas:
read_limit == 0(read ops are skipped andstart_buf_indexis never set)This is an automatic backport of pull request fix(fs): handle reads for file with zero size / limit #10900 done by Mergify.