Skip to content

Enable direct io for blockstore_db reads and writes #10907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dachen0 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Enable direct io for blockstore_db reads and writes #10907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7706e0
enable direct io for blockstore_db reads and writes
dachen0 Mar 2, 2026
5bcdd9c
use `check_direct_io_capability` to toggle dio on rocksdb
dachen0 Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions ledger/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ agave-unstable-api = []

[dependencies]
agave-feature-set = { workspace = true }
agave-fs = { workspace = true }
agave-reserved-account-keys = { workspace = true }
agave-snapshots = { workspace = true }
agave-votor-messages = { workspace = true }
Expand Down
20 changes: 17 additions & 3 deletions ledger/src/blockstore_db.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ impl Rocks {
fs::create_dir_all(&path)?;

// Use default database options
let mut db_options = get_db_options(&options);
let mut db_options = get_db_options(&options, &path)?;
if let Some(recovery_mode) = recovery_mode {
db_options.set_wal_recovery_mode(recovery_mode.into());
}
Expand Down Expand Up @@ -1144,13 +1144,27 @@ fn process_cf_options_advanced<C: 'static + Column + ColumnName>(
}
}

fn get_db_options(blockstore_options: &BlockstoreOptions) -> Options {
fn get_db_options(
blockstore_options: &BlockstoreOptions,
path: &PathBuf,
) -> std::io::Result<Options> {
let mut options = Options::default();

// Create missing items to support a clean start
options.create_if_missing(true);
options.create_missing_column_families(true);

// Direct io
#[cfg(target_os = "linux")]
{
use agave_fs::metadata::DirectIoSupport;

if agave_fs::metadata::check_direct_io_capability(path)? == DirectIoSupport::Supported {
options.set_use_direct_io_for_flush_and_compaction(true);
options.set_use_direct_reads(true);
}
}
Comment thread
dachen0 marked this conversation as resolved.

// rocksdb builds two threadpools: low and high priority. The low priority
// pool is used for compactions whereas the high priority pool is used for
// memtable flushes. Separate pools are created so that compactions are
Expand Down Expand Up @@ -1183,7 +1197,7 @@ fn get_db_options(blockstore_options: &BlockstoreOptions) -> Options {
// it is not required for read-only access, but should be fine with our high ulimit.
options.set_max_open_files(-1);

options
Ok(options)
}

/// The default number of threads to use for rocksdb compaction in the rocksdb
Expand Down