Adds StorableAccounts::account_for_geyser()#10352
Merged
brooksprumo merged 1 commit intoanza-xyz:masterfrom Feb 4, 2026
Merged
Adds StorableAccounts::account_for_geyser()#10352brooksprumo merged 1 commit intoanza-xyz:masterfrom
brooksprumo merged 1 commit intoanza-xyz:masterfrom
Conversation
brooksprumo
force-pushed
the
geyser/store-accounts-2
branch
from
2f1cad6 to
8113e06
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #10352 +/- ##
=========================================
- Coverage 83.2% 83.2% -0.1%
=========================================
Files 845 845
Lines 319740 319920 +180
=========================================
+ Hits 266099 266238 +139
- Misses 53641 53682 +41 🚀 New features to boost your workflow:
|
brooksprumo
force-pushed
the
geyser/store-accounts-2
branch
3 times, most recently
from
8d92a38 to
22086f5
Compare
brooksprumo
commented
Feb 4, 2026
| let transaction = transactions | ||
| .map(|txs| *txs.get(index).expect("txs must be present if provided")); | ||
| accounts.account(index, |account| { | ||
| let account_shared_data = account.take_account(); |
Author
There was a problem hiding this comment.
We now no longer need to call .take_account() to create an AccountSharedData.
roryharr
previously approved these changes
Feb 4, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
brooksprumo
force-pushed
the
geyser/store-accounts-2
branch
from
22086f5 to
32f5a85
Compare
Author
|
Had to rebase on latest master to resolve merge conflicts with #10343 (a field was renamed within partitioned epoch rewards). No other code changes were made. |
roryharr
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Geyser account update notifications are sent out in
Accounts::_store_accounts(). The fn is passed in aimpl StorableAccounts, but the geyser notifications need a&AccountSharedData. Right now we have to make a new AccountSharedData just to take a reference and give it to geyser. We know for_store_accounts()that the underlyingStorableAccountswill haveAccountSharedDatas, so it would be better to get access to that directly.Summary of Changes
Adds StorableAccounts::account_for_geyser(), which provides
&AccountSharedDatain its callback. This obviates the need for making a new AccountSharedData.