Skip to content

svm: remove redundant runtime environment clone#10119

Merged
LucasSte merged 1 commit intoanza-xyz:masterfrom
radik878:fix/reduce-runtime-env-clone
Jan 28, 2026
Merged

svm: remove redundant runtime environment clone#10119
LucasSte merged 1 commit intoanza-xyz:masterfrom
radik878:fix/reduce-runtime-env-clone

Conversation

@radik878
Copy link
Copy Markdown

Before this change we cloned the program runtime environment twice per load call (once at the call site and again inside load_program_from_bytes), which was unnecessary because Arc cloning is already done when passing the environment in.
Removed the redundant internal clone so the runtime environment is moved into ProgramCacheEntry::new/reload without extra refcount churn.

@radik878 radik878 requested a review from a team as a code owner January 20, 2026 12:05
@Lichtso Lichtso added the CI Pull Request is ready to enter CI label Jan 20, 2026
@anza-team anza-team removed the CI Pull Request is ready to enter CI label Jan 20, 2026
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.6%. Comparing base (590832c) to head (b07e34d).

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #10119     +/-   ##
=========================================
- Coverage    82.6%    82.6%   -0.1%     
=========================================
  Files         845      845             
  Lines      317132   317132             
=========================================
- Hits       262005   262001      -4     
- Misses      55127    55131      +4     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

nagisa added a commit to nagisa/agave that referenced this pull request Jan 20, 2026
I saw anza-xyz#10119 and figured that we might as well enable the perf related
lints in our code to get less of these issues landed in the first place.
nagisa added a commit to nagisa/agave that referenced this pull request Jan 28, 2026
I saw anza-xyz#10119 and figured that we might as well enable the perf related
lints in our code to get less of these issues landed in the first place.
nagisa added a commit to nagisa/agave that referenced this pull request Jan 28, 2026
I saw anza-xyz#10119 and figured that we might as well enable the perf related
lints in our code to get less of these issues landed in the first place.
@LucasSte LucasSte added this pull request to the merge queue Jan 28, 2026
Merged via the queue into anza-xyz:master with commit 08e48dd Jan 28, 2026
51 checks passed
nagisa added a commit to nagisa/agave that referenced this pull request Jan 28, 2026
I saw anza-xyz#10119 and figured that we might as well enable the perf related
lints in our code to get less of these issues landed in the first place.
nagisa added a commit to nagisa/agave that referenced this pull request Jan 28, 2026
I saw anza-xyz#10119 and figured that we might as well enable the perf related
lints in our code to get less of these issues landed in the first place.
nagisa added a commit to nagisa/agave that referenced this pull request Jan 28, 2026
I saw anza-xyz#10119 and figured that we might as well enable the perf related
lints in our code to get less of these issues landed in the first place.
nagisa added a commit to nagisa/agave that referenced this pull request Feb 2, 2026
I saw anza-xyz#10119 and figured that we might as well enable the perf related
lints in our code to get less of these issues landed in the first place.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants