svm: remove redundant runtime environment clone#10119
Merged
LucasSte merged 1 commit intoanza-xyz:masterfrom Jan 28, 2026
Merged
svm: remove redundant runtime environment clone#10119LucasSte merged 1 commit intoanza-xyz:masterfrom
LucasSte merged 1 commit intoanza-xyz:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10119 +/- ##
=========================================
- Coverage 82.6% 82.6% -0.1%
=========================================
Files 845 845
Lines 317132 317132
=========================================
- Hits 262005 262001 -4
- Misses 55127 55131 +4 🚀 New features to boost your workflow:
|
Lichtso
approved these changes
Jan 20, 2026
nagisa
added a commit
to nagisa/agave
that referenced
this pull request
Jan 20, 2026
I saw anza-xyz#10119 and figured that we might as well enable the perf related lints in our code to get less of these issues landed in the first place.
nagisa
added a commit
to nagisa/agave
that referenced
this pull request
Jan 28, 2026
I saw anza-xyz#10119 and figured that we might as well enable the perf related lints in our code to get less of these issues landed in the first place.
nagisa
added a commit
to nagisa/agave
that referenced
this pull request
Jan 28, 2026
I saw anza-xyz#10119 and figured that we might as well enable the perf related lints in our code to get less of these issues landed in the first place.
nagisa
added a commit
to nagisa/agave
that referenced
this pull request
Jan 28, 2026
I saw anza-xyz#10119 and figured that we might as well enable the perf related lints in our code to get less of these issues landed in the first place.
nagisa
added a commit
to nagisa/agave
that referenced
this pull request
Jan 28, 2026
I saw anza-xyz#10119 and figured that we might as well enable the perf related lints in our code to get less of these issues landed in the first place.
nagisa
added a commit
to nagisa/agave
that referenced
this pull request
Jan 28, 2026
I saw anza-xyz#10119 and figured that we might as well enable the perf related lints in our code to get less of these issues landed in the first place.
nagisa
added a commit
to nagisa/agave
that referenced
this pull request
Feb 2, 2026
I saw anza-xyz#10119 and figured that we might as well enable the perf related lints in our code to get less of these issues landed in the first place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change we cloned the program runtime environment twice per load call (once at the call site and again inside load_program_from_bytes), which was unnecessary because Arc cloning is already done when passing the environment in.
Removed the redundant internal clone so the runtime environment is moved into ProgramCacheEntry::new/reload without extra refcount churn.