refactor(programs): use if let Some instead of unwrap for not is_none#10069
Merged
kskalski merged 1 commit intoanza-xyz:masterfrom Jan 16, 2026
Merged
refactor(programs): use if let Some instead of unwrap for not is_none#10069kskalski merged 1 commit intoanza-xyz:masterfrom
kskalski merged 1 commit intoanza-xyz:masterfrom
Conversation
|
The Firedancer team maintains a line-for-line reimplementation of the |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #10069 +/- ##
=======================================
Coverage 82.6% 82.6%
=======================================
Files 844 844
Lines 316607 316607
=======================================
+ Hits 261552 261565 +13
+ Misses 55055 55042 -13 🚀 New features to boost your workflow:
|
Lichtso
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The code in
process_loader_upgradeable_instruction(is checking option twice:Summary of Changes
Flip if branches such that
if let Some(x) = xcan be used insteadNote: this was caught with newer (1.92) rust toolchain and emits warning, which this PR is fixing