Skip to content

Switch networking crates to Rust 2024 edition#10067

Merged
alexpyattaev merged 3 commits intoanza-xyz:masterfrom
kskalski:ks/ed2024_net_narrow
Jan 16, 2026
Merged

Switch networking crates to Rust 2024 edition#10067
alexpyattaev merged 3 commits intoanza-xyz:masterfrom
kskalski:ks/ed2024_net_narrow

Conversation

@kskalski
Copy link
Copy Markdown

@kskalski kskalski commented Jan 16, 2026

Problem

Rust 2024 migration is now possible for monorepo. Most of the code do not have any semantic changes and is only affected by formatting style switch, some exceptions do exist, mostly in order of drops, which should be reviewed, e.g. w.r.t. possible locking behavior change.

The semantic changes (caused by if-let-rescope, tail-expr-drop-order, edition-2024-expr-fragment-specifier) can be detected running cargo fix --edition and in case of this PR they generate a few cases as attached below

cargo +nightly-2025-09-14 fix --edition -p solana-bloom -p solana-gossip -p solana-net-utils -p solana-tls-utils -p solana-turbine 

yields
networking_tail_expr.txt
networking_expr_fragment.txt
networking_if_let_rescope - no code has semantic changes

Summary of Changes

  • switch crates owned by networking (without parts of core) to Rust 2024 edition
  • update formatting per 2024 style
  • fix collapsible if warnings

Note: styling change can be decoupled from switching edition, but it can only be done for the whole workspace and be done shortly before new release cut

Reviewing

Probably the best way to review is to git diff -w individual commits or possibly re-generate this PR locally to see for identical results from:

  • cherry-pick e0f81b1 (edition switches)
  • cargo +nightly-2025-09-14 fmt --all
  • cargo +nightly-2025-09-14 clippy --workspace --all-targets --fix --features dummy-for-ci-check,frozen-abi -- --deny=warnings --deny=clippy::default_trait_access --deny=clippy::arithmetic_side_effects --deny=clippy::manual_let_else --deny=clippy::uninlined-format-args --deny=clippy::used_underscore_binding - collapsible if fix

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 16, 2026

Codecov Report

❌ Patch coverage is 85.14493% with 41 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.6%. Comparing base (4065e4a) to head (9d9ee32).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10067   +/-   ##
=======================================
  Coverage    82.6%    82.6%           
=======================================
  Files         844      844           
  Lines      316607   316631   +24     
=======================================
+ Hits       261552   261572   +20     
- Misses      55055    55059    +4     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kskalski kskalski marked this pull request as ready for review January 16, 2026 04:36
@kskalski kskalski requested a review from a team as a code owner January 16, 2026 04:36
@kskalski kskalski force-pushed the ks/ed2024_net_narrow branch from c50bf8c to 9d9ee32 Compare January 16, 2026 10:39
@alexpyattaev alexpyattaev self-requested a review January 16, 2026 10:43
Copy link
Copy Markdown

@alexpyattaev alexpyattaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@alexpyattaev alexpyattaev added this pull request to the merge queue Jan 16, 2026
Merged via the queue into anza-xyz:master with commit 0e59c0b Jan 16, 2026
58 checks passed
@kskalski kskalski deleted the ks/ed2024_net_narrow branch February 23, 2026 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants