Switch networking crates to Rust 2024 edition#10067
Merged
alexpyattaev merged 3 commits intoanza-xyz:masterfrom Jan 16, 2026
Merged
Switch networking crates to Rust 2024 edition#10067alexpyattaev merged 3 commits intoanza-xyz:masterfrom
alexpyattaev merged 3 commits intoanza-xyz:masterfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #10067 +/- ##
=======================================
Coverage 82.6% 82.6%
=======================================
Files 844 844
Lines 316607 316631 +24
=======================================
+ Hits 261552 261572 +20
- Misses 55055 55059 +4 🚀 New features to boost your workflow:
|
c50bf8c to
9d9ee32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Rust 2024 migration is now possible for monorepo. Most of the code do not have any semantic changes and is only affected by formatting style switch, some exceptions do exist, mostly in order of drops, which should be reviewed, e.g. w.r.t. possible locking behavior change.
The semantic changes (caused by if-let-rescope, tail-expr-drop-order, edition-2024-expr-fragment-specifier) can be detected running
cargo fix --editionand in case of this PR they generate a few cases as attached belowyields
networking_tail_expr.txt
networking_expr_fragment.txt
networking_if_let_rescope - no code has semantic changes
Summary of Changes
Note: styling change can be decoupled from switching edition, but it can only be done for the whole workspace and be done shortly before new release cut
Reviewing
Probably the best way to review is to
git diff -windividual commits or possibly re-generate this PR locally to see for identical results from:cargo +nightly-2025-09-14 fmt --allcargo +nightly-2025-09-14 clippy --workspace --all-targets --fix --features dummy-for-ci-check,frozen-abi -- --deny=warnings --deny=clippy::default_trait_access --deny=clippy::arithmetic_side_effects --deny=clippy::manual_let_else --deny=clippy::uninlined-format-args --deny=clippy::used_underscore_binding- collapsible if fix