Skip to content

Fix tests that are not rooting slots when they should. Added assert#10038

Merged
roryharr merged 1 commit intoanza-xyz:masterfrom
roryharr:fix_unrooted_slot_tests
Jan 15, 2026
Merged

Fix tests that are not rooting slots when they should. Added assert#10038
roryharr merged 1 commit intoanza-xyz:masterfrom
roryharr:fix_unrooted_slot_tests

Conversation

@roryharr
Copy link
Copy Markdown

@roryharr roryharr commented Jan 15, 2026

Problem

Some tests are unintentionally running on unrooted slots. While it may be valid to test, it could lead to unintentional test behaviour if not known explicitly.

Summary of Changes

  • Fix the tests
  • Make sure no other tests do the same by adding an assert

Fixes #

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.6%. Comparing base (a79a700) to head (3000bfe).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #10038       +/-   ##
===========================================
+ Coverage    70.9%    82.6%    +11.6%     
===========================================
  Files         711      844      +133     
  Lines      211507   316654   +105147     
===========================================
+ Hits       150014   261634   +111620     
+ Misses      61493    55020     -6473     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@roryharr roryharr requested a review from brooksprumo January 15, 2026 22:34
@roryharr roryharr marked this pull request as ready for review January 15, 2026 22:34
Copy link
Copy Markdown

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@roryharr roryharr added this pull request to the merge queue Jan 15, 2026
Merged via the queue into anza-xyz:master with commit 45a18bd Jan 15, 2026
47 checks passed
@roryharr roryharr deleted the fix_unrooted_slot_tests branch January 15, 2026 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants