Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Go dependency from homebrew #938

Merged

Conversation

cuminandpaprika
Copy link
Contributor

This commit removes the Go dependency from the homebrew goreleaser config. Most of the current users of Sysl are Go developers and we the current homebrew formula interferes with the local installation of Go, and can cause unintended upgrades to the Go version.

Checklist:

  • Added related tests
  • Made corresponding changes to the documentation

This commit removes the Go dependency from the homebrew goreleaser config. Most of the current users of Sysl are Go developers and we the current homebrew formula interferes with the local installation of Go, and can cause unintended upgrades to the Go version.
@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #938 into master will increase coverage by 0.67%.
The diff coverage is 83.77%.

@@            Coverage Diff             @@
##           master     #938      +/-   ##
==========================================
+ Coverage   83.35%   84.03%   +0.67%     
==========================================
  Files          73       74       +1     
  Lines       10609    10301     -308     
==========================================
- Hits         8843     8656     -187     
+ Misses       1432     1335      -97     
+ Partials      334      310      -24     
Impacted Files Coverage Δ
pkg/pbutil/output.go 76.00% <ø> (-0.48%) ⬇️
pkg/parse/listener_impl.go 89.50% <54.54%> (-0.01%) ⬇️
pkg/importer/importer.go 63.15% <63.15%> (ø)
pkg/mod/gomod.go 73.68% <66.66%> (+1.27%) ⬆️
pkg/parse/parse.go 83.47% <69.56%> (-0.50%) ⬇️
pkg/mod/module.go 66.66% <72.72%> (+0.95%) ⬆️
pkg/importer/formats.go 77.27% <77.27%> (ø)
pkg/importer/openapi.go 81.73% <80.71%> (-7.72%) ⬇️
pkg/importer/swagger.go 81.48% <88.88%> (+1.88%) ⬆️
pkg/importer/xsd.go 91.01% <95.23%> (+0.64%) ⬆️
... and 13 more

@cuminandpaprika cuminandpaprika merged commit 6592114 into anz-bank:master Jul 17, 2020
@cuminandpaprika cuminandpaprika deleted the jack/remove-homebrew-go branch July 17, 2020 04:58
anzopensource pushed a commit that referenced this pull request Aug 21, 2024
* Remove sourceContext from the json when compact

* for loop on 1 line

* simplify

* keep sourceContext for Imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants