Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated int and float to add new attr bid_width. #1042

Merged
merged 12 commits into from
Sep 3, 2020
Merged

Updated int and float to add new attr bid_width. #1042

merged 12 commits into from
Sep 3, 2020

Conversation

ericzhang6222
Copy link
Contributor

@ericzhang6222 ericzhang6222 commented Sep 2, 2020 •
edited
Loading

  • Please attach WIP tag when this PR is still work in progress.
  • Please attach breaking-change tag if this PR potentially causes other components to fail or changes previous sysl executable's behaviour.

Fixes #1011 .

Changes proposed in this pull request:

  • Added new attribute bitWidth for int and 'float' to identify its bit length.

Checklist:

  • Added related tests
  • Made corresponding changes to the documentation

@ericzhang6222 ericzhang6222 marked this pull request as draft September 2, 2020 03:31
@codecov
Copy link

codecov bot commented Sep 2, 2020 •
edited
Loading

Codecov Report

Merging #1042 into master will increase coverage by 1.14%.
The diff coverage is 84.05%.

@@            Coverage Diff             @@
##           master    #1042      +/-   ##
==========================================
+ Coverage   83.35%   84.49%   +1.14%     
==========================================
  Files          73       73              
  Lines       10609    10521      -88     
==========================================
+ Hits         8843     8890      +47     
+ Misses       1432     1324     -108     
+ Partials      334      307      -27
Impacted Files Coverage Δ
pkg/database/db_test_utils.go 83.33% <0.00%> (ø)
pkg/diagrams/plantuml.go 0.00% <0.00%> (ø)
pkg/mod/fs.go 58.44% <50.00%> (-11.37%) ⬇️
pkg/importer/importer.go 63.15% <63.15%> (ø)
pkg/mermaid/datamodeldiagram/datamodeldiagram.go 61.90% <68.42%> (+3.33%) ⬆️
pkg/parse/parse.go 85.01% <71.87%> (+1.03%) ⬆️
pkg/parse/listener_impl.go 88.75% <76.34%> (-0.76%) ⬇️
pkg/parse/fs.go 90.90% <80.00%> (-9.10%) ⬇️
...g/mermaid/integrationdiagram/integrationdiagram.go 83.19% <82.45%> (-1.19%) ⬇️
pkg/importer/openapi.go 86.12% <85.45%> (-3.32%) ⬇️
... and 29 more

@ericzhang6222 ericzhang6222 marked this pull request as ready for review September 2, 2020 08:00
andrewemeryanz
andrewemeryanz requested changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@andrewemeryanz andrewemeryanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes requested.

pkg/parse/tests/numbers_format.sysl Outdated Show resolved Hide resolved
pkg/parse/utils.go Show resolved Hide resolved
pkg/parse/utils.go Outdated Show resolved Hide resolved
andrewemeryanz
andrewemeryanz requested changes Sep 3, 2020
View reviewed changes
pkg/sysl/sysl.proto Outdated Show resolved Hide resolved
@ericzhang6222 ericzhang6222 changed the title Updated int and float to add new attr bitWidth. Updated int and float to add new attr bid_width. Sep 3, 2020
@ericzhang6222 ericzhang6222 merged commit cfcff97 into master Sep 3, 2020
@ericzhang6222 ericzhang6222 deleted the int_float_support branch September 3, 2020 03:36
joshcarp pushed a commit that referenced this pull request Sep 15, 2020
@ericzhang6222
Sync external Sysl repo branch master changes to internal Sysl repo (#…
8bf5f02 
…169)

Sync external Sysl repo branch master changes to internal Sysl repo:
1. Replace anz-bank/sysl/pkg/mod with anz-bank/pkg/mod (#1038)
2. Fix GitHub API based sysl modules single file cache issue (#1043)
3. Updated int and float to add new attr bid_width. (#1042)
4. Fix mod init (#1045)
ChloePlanet added a commit that referenced this pull request Sep 22, 2020
@ericzhang6222 @ChloePlanet @lordofpm
Avro import (#182)
0e1d192 
* Replace anz-bank/sysl/pkg/mod with anz-bank/pkg/mod (#1038)

* replace anz-bank/sysl/pkg/mod with anz-bank/pkg/mod

* Fix GitHub API based sysl modules single file cache issue (#1043)

* upgrade anz-bank/pkg to v0.0.17
* Show proper error info with github api error

* Updated int and float to add new attr bid_width. (#1042)

Updated to support int32, int64 , float32, float64 and their length with bid_width.

* fix mod init (#1045)

* Rebase avro import code.

* Corrected comments.

* Updated code to make it is more simple and clear.

* Added more comments.

* Added new line in the end of output Sysl file.

Co-authored-by: Chloe <[email protected]>
Co-authored-by: ericzhang6222 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewemeryanz andrewemeryanz andrewemeryanz approved these changes

@orlade-anz orlade-anz Awaiting requested review from orlade-anz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for float32 and float64 types
2 participants
@ericzhang6222 @andrewemeryanz