-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lab3 #478
Lab3 #478
Conversation
Implement letters() and sortLetters() and some tests for them. Stil need to fix test cases and understand table driven testing
Get familiar with table driven testing based on the following article https://dave.cheney.net/2019/05/07/prefer-table-driven-tests
Codecov Report
@@ Coverage Diff @@
## master #478 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 108 109 +1
Lines 1878 1894 +16
=====================================
+ Hits 1878 1894 +16
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed you could be making use of the assert package to improve the brevity of your unit tests, aside from that it looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work and test coverage.
I would like you to remove all the extra newlines. As for testify, treat it as optional but recommended.
for _, char := range s { | ||
count[char]++ | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
// note that Sprintf returns u a formatted string it doesn't print anything | ||
|
||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Erased from existence
Mainly around unnecessary whitespace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #477
Review of colleague's PR #457
Changes proposed in this PR: