Lab3 #478
Merged
Lab3 #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 7, 2019 10:35
Implement letters() and sortLetters() and some tests for them. Stil need to fix test cases and understand table driven testing
Get familiar with table driven testing based on the following article https://dave.cheney.net/2019/05/07/prefer-table-driven-tests
nicko-lee
requested review from
anzdaddy,
camscale,
joshcarp,
juliaogris,
linuxmonk and
pentaphobe
as code owners
Codecov Report
@@ Coverage Diff @@
## master #478 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 108 109 +1
Lines 1878 1894 +16
=====================================
+ Hits 1878 1894 +16
Continue to review full report at Codecov.
|
nicholascross
previously requested changes
Jun 24, 2019
Closed
anzboi
requested changes
Jun 26, 2019
| for _, char := range s { | ||
| count[char]++ | ||
| } | ||
|
|
| // note that Sprintf returns u a formatted string it doesn't print anything | ||
|
|
||
| } | ||
|
|
There was a problem hiding this comment.
Erased from existence
Mainly around unnecessary whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #477
Review of colleague's PR #457
Changes proposed in this PR: