Updated PR review fixes

anz-bank · Jul 12, 2019 · cb10257 · cb10257
1 parent 641acb2
commit cb10257
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/04_numeronym/sirigithub/main.go b/04_numeronym/sirigithub/main.go
@@ -13,11 +13,10 @@ func numeronyms(vals ...string) []string {
 	for i, val := range vals {
 		r := []rune(val)
 		runeLength := len(r)
-		if runeLength < 4 {
-			result[i] = val
-		} else {
-			result[i] = fmt.Sprintf("%c%d%c", r[0], runeLength-2, r[runeLength-1])
+		if runeLength > 3 {
+			val = fmt.Sprintf("%c%d%c", r[0], runeLength-2, r[runeLength-1])
 		}
+		result[i] = val
 	}
 	return result
 }

diff --git a/04_numeronym/sirigithub/main_test.go b/04_numeronym/sirigithub/main_test.go
@@ -36,9 +36,10 @@ func TestNumeronyms(t *testing.T) {
 			expected: []string{"a6$", "*3]"}},
 	}
 	for _, test := range tests {
-		actual := numeronyms(test.input...)
-		expected := test.expected
+		test := test
 		t.Run(test.description, func(t *testing.T) {
+			actual := numeronyms(test.input...)
+			expected := test.expected
 			assert.Equal(t, actual, expected, "actual %v but expected %v", actual, expected)
 		})
 	}